Fix const value root font size loading #2
+12
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the value is a const such as 'small' a casting error is thrown
ddunkin
reviewed
Jan 13, 2025
| @@ -287,6 +287,10 @@ public Double ToPixel(IRenderDimensions renderDimensions) | |||
| return _value * 96.0 / 72.0; | |||
| case Unit.Cm: // 1 cm = 50/127 in | |||
| return _value * 50.0 * 96.0 / 127.0; | |||
| case Unit.Ex: | |||
| CheckForValidRenderDimensionsForFont(renderDimensions); | |||
| // 1ex is the x-height of the font, or half of 1em. | |||
There was a problem hiding this comment.
This isn't true. It depends on the font. If there are places where we can use an approximate value, can we do that calculation there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes these errors
I also implemented
Exunits and improved logging for unsupported units while i was in here.CON-1021